Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing ipaddr requirement #219

Closed
wants to merge 1 commit into from
Closed

Conversation

kfreezen
Copy link

Two changes:

  1. python >= 3.6.1 -- poetry install did not like pre-commit = "2.16.0"
  2. Changed ipaddress back to ipaddr and added a python <3.3 to avoid installing ipaddr on python versions 3.3 and above.

The code seems to already handle ipaddress/ipaddr shift in code already, so change number 2 should be fine from a code perspective.

@kido5217
Copy link

kido5217 commented Jan 25, 2022

According to my experience, general python dependency should be specified without patch version, or pypi will not mark package as 3.6 compatible, only as 3.7+
Specific python version for pre-commit should be listed for pre-commit only:

pre-commit = {version = "2.16.0", python = "^3.6.1"}

mpenning added a commit that referenced this pull request Jan 26, 2022
@mpenning
Copy link
Owner

Thank you for your PR, but this PR doesn't do what we want now... we don't want to deal with anything related to ipaddr at this point

@mpenning mpenning closed this Jan 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants