Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit namespaces for Mutex and ConditionVariable #153

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

deivid-rodriguez
Copy link
Contributor

This upstreams this PR to the rubygems repository: rubygems/rubygems#4709.

Using the explicit Thread namespace is the future-proof way of accessing these constants.

This upstreams this PR to the rubygems repository:
rubygems/rubygems#4709.

Using the explicit `Thread` namespace is the future-proof way of
accessing these constants.
@mperham mperham merged commit 0870c11 into mperham:master Jul 8, 2021
@deivid-rodriguez deivid-rodriguez deleted the explicit_namespaces branch July 8, 2021 15:15
@deivid-rodriguez
Copy link
Contributor Author

Thanks for merging! ❤️

I noticed though that according to rubygems/rubygems#4709 (comment), Thread::Mutex was introduced on ruby 2.3, and this library supports down to ruby 2.2 included. So this will break ruby 2.2 support.

I can:

  • Create a PR bumping the minimum supported ruby to 2.3.
  • Create a PR reverting this PR, and will keep our custom patch until you drop support.

Let me know which one you prefer.

@mperham
Copy link
Owner

mperham commented Jul 8, 2021

We can drop 2.2, but let’s bump our version to 2.3 and add it to the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants