Add a piece length option to the torrent creator CLI #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. See my comments. Also fix the typo in the commit message. |
rambegaokar
pushed a commit
to rambegaokar/ttorrent
that referenced
this pull request
Nov 25, 2014
|
Review updated to address the comments. |
|
Cool. Do you mind squashing your two commits together? Then we're good to merge! |
|
Done. |
|
Can we close the review if all is good? |
mpetazzoni
added a commit
that referenced
this pull request
Dec 31, 2014
Add a piece length option to the torrent creator CLI
|
Sure, sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request for review to add capabilty to define the piece length option while creating torrents via the CLI.