Refactored out dependency on log4j. #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are now two submodules in this project, cli and core.
Closed
|
Looks great! Thanks! This will probably warrant a new point release to deploy new JARs to Maven Central. |
mpetazzoni
added a commit
that referenced
this pull request
Feb 20, 2015
Refactored out dependency on log4j.
|
By the way, would you mind updating the README with the correct POM info in the example? |
|
Here is the readme pull: #121 |
|
You may also have noticed that I commented out the dependency for testng. |
|
Re: testng- I just realized the test folder is incorrect. The test folder should be src/test/java/ and then the dependency will be required. |
|
Yep, mind fixing this too? Thanks! |
|
Thanks all for the efforts. I'll try to embedd this version in my web application, so I can remove my fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are now two submodules in this project, cli and core.