Remove dependency on Apache comons-codec #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is PR #146 minus the gradle configuration for Android |
|
Thanks! I have a few comments though |
philipphenkel
force-pushed
the
develop
branch
from
13c3a14 to
22fb57a
Compare
|
Good proposals! I reworked the original PR and pushed a new one. NoSuchAlgorithmException is now propagated and that's why more files are affected. |
|
Thanks, just two little things left that you missed |
mpetazzoni
changed the title
Resolves: mpetazzoni#144 See also: mpetazzoni#146
philipphenkel
force-pushed
the
develop
branch
from
22fb57a to
7fc5279
Compare
|
Oops, somehow I messed up the rebase. Thanks for the quick feedback - it should be fine now. |
mpetazzoni
added a commit
that referenced
this pull request
Jan 22, 2016
Remove dependency on Apache comons-codec
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Isolated PR with Andre's fixes for #144