Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that PHP 7.2 and 7.3 show tons of warnings about
null
not beingCountable
, however, they do not break the build.It's a known issue in this version of PHPUnit. There is a fix, but the maintainer of PHPUnit is not interested in back-porting to PHPUnit 4.x or even 5.x.
sebastianbergmann/php-code-coverage#554
PHPUnit 4.x PR: sebastianbergmann/php-code-coverage#590
PHPUnit 5.x PR: sebastianbergmann/php-code-coverage#591
So in order for tests to run perfectly clean under PHP 7.2 and 7.3, we need to upgrade PHPUnit to at least 6.x, which kills support for PHP 5.x (minimum supported: PHP 7.0)
I think we can live with the warnings for the time being, but should consider dropping support for older PHP versions in the near future.