Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rendering .hp files broken in recent release #191

Open
mpickering opened this issue Sep 27, 2024 · 2 comments · May be fixed by #192
Open

Rendering .hp files broken in recent release #191

mpickering opened this issue Sep 27, 2024 · 2 comments · May be fixed by #192

Comments

@mpickering
Copy link
Owner

The -p option to render a .hp file is broken in recent releases.

The problem is the check to see whether there is profiling data to display checks hHeapProfilingType which is set to Nothing in -p mode.
@BinderDavid
Copy link
Collaborator

Is there still a legitimate use for using .hp files? So should we fix it or remove the functionality?

mpickering added a commit that referenced this issue Sep 27, 2024
@mpickering
Fix render of heap profiles in -p mode
e73328b 
Fixes #191
@mpickering mpickering linked a pull request Sep 27, 2024 that will close this issue
Open
@mpickering
Copy link
Owner Author

@BinderDavid Well, I discovered this by trying to use a .hp file, I don't see a particular reason to remove the functionality whilst GHC still produces them by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix render of heap profiles in -p mode mpickering/eventlog2html
2 participants
@mpickering @BinderDavid