Refactor to parse Mongo messages from buffer #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpihlak
force-pushed
the
refactor-to-buffer
branch
from
0208831 to
48046b4
Compare
This removes the small allocations on reading from the network that eventually lead to high memory usage in the proxy.
In theory the async streaming parser could offer better memory usage, but not having it results in easier to maintain code (no is_sync, maybe_async, async recursion madness etc.). Good riddance.
mpihlak
force-pushed
the
refactor-to-buffer
branch
from
f9b0a1b to
b199e57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces memory allocations by using a single read buffer for the duration of the connection. Actually two buffers -- one from reading from client and another from server. Tracker is refactored to take already parsed Mongo message, thus avoiding the need to ship the whole buffer over to another task.
Also the following cleanups were applied:
async-bson- now it assumes that it always has the full buffer to parse.