Add custom logo support #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #368 +/- ##
============================================
- Coverage 92.02% 91.48% -0.55%
- Complexity 191 192 +1
============================================
Files 10 10
Lines 489 493 +4
============================================
+ Hits 450 451 +1
- Misses 39 42 +3
Continue to review full report at Codecov.
|
shalvah
suggested changes
Oct 13, 2018
config/apidoc.php
Outdated
| * Custom logo path. Will be copied during generate command. | ||
| * | ||
| * If you want to use this, please be aware of the following rules: | ||
| * - filename: logo.png |
There was a problem hiding this comment.
I think the requirement on the filename can be removed, since they're providing the full path, including the filename.
config/apidoc.php
Outdated
| @@ -87,4 +87,16 @@ | |||
| ], | |||
| ], | |||
| ], | |||
|
|
|||
| /* | |||
| * Custom logo path. Will be copied during generate command. | |||
There was a problem hiding this comment.
Can you add an explanation for the default? Something like "Set this to false to use the default logo". Also, please update the documentation.
shalvah
approved these changes
Oct 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible solution for the feature request I've opened earlier: #367