Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace config_path() by generic code #398

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Replace config_path() by generic code #398

merged 1 commit into from
Oct 31, 2018

Conversation

DaazKu
Copy link
Contributor

@DaazKu DaazKu commented Oct 31, 2018

config_path() does not exists in "Vanilla" lumen.
It may be defined by some plugins but by default it does not exists.

Fixes:
screen shot 2018-10-31 at 3 49 59 pm

@shalvah
Copy link
Contributor

shalvah commented Oct 31, 2018

I assume 'basePath' does not return a path with a trailing slash?

@shalvah shalvah merged commit 7d4e6f3 into mpociot:master Oct 31, 2018
@codecov-io
Copy link

Codecov Report

Merging #398 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #398   +/-   ##
=========================================
  Coverage     91.32%   91.32%           
  Complexity      204      204           
=========================================
  Files            10       10           
  Lines           519      519           
=========================================
  Hits            474      474           
  Misses           45       45

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ddd9c6...e7e2722. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants