Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support partial resource controller #429

Merged
merged 3 commits into from
Dec 12, 2018

Conversation

phanan
Copy link
Contributor

@phanan phanan commented Dec 11, 2018

This PR fixes #426.

@codecov-io
Copy link

codecov-io commented Dec 11, 2018

Codecov Report

Merging #429 into master will increase coverage by 0.25%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #429      +/-   ##
============================================
+ Coverage     91.68%   91.94%   +0.25%     
- Complexity      225      226       +1     
============================================
  Files            11       11              
  Lines           541      546       +5     
============================================
+ Hits            496      502       +6     
+ Misses           45       44       -1
Impacted Files Coverage Δ Complexity Δ
src/Commands/GenerateDocumentation.php 95.65% <100%> (+0.96%) 36 <0> (+1) ⬆️
...c/Tools/ResponseStrategies/ResponseTagStrategy.php 100% <0%> (ø) 11% <0%> (ø) ⬇️
.../Tools/ResponseStrategies/ResponseFileStrategy.php 100% <0%> (ø) 11% <0%> (ø) ⬇️
...ols/ResponseStrategies/TransformerTagsStrategy.php 86.36% <0%> (+0.31%) 23% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdfb6c6...6096b95. Read the comment docs.

@shalvah
Copy link
Contributor

shalvah commented Dec 12, 2018

Looks like Travis had a problem. Try pushing an empty commit to re-enter trigger the build.

@phanan
Copy link
Contributor Author

phanan commented Dec 12, 2018

@shalvah Can't you rebuild from Travis's UI?

@shalvah
Copy link
Contributor

shalvah commented Dec 12, 2018 via email

@shalvah
Copy link
Contributor

shalvah commented Dec 12, 2018

Thank you.

@shalvah shalvah merged commit c2ef79d into mpociot:master Dec 12, 2018
@phanan phanan deleted the fix/partial-ctrl branch December 12, 2018 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc generation fails if resource controller is partial
3 participants