-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom serializer #441
Custom serializer #441
Conversation
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
==========================================
+ Coverage 91.97% 92% +0.02%
- Complexity 228 229 +1
==========================================
Files 11 11
Lines 548 550 +2
==========================================
+ Hits 504 506 +2
Misses 44 44
Continue to review full report at Codecov.
|
Signed-off-by: Lloric Mayuga Garcia <lloricode@gmail.com>
Signed-off-by: Lloric Mayuga Garcia <lloricode@gmail.com>
hmmm I've notice that the $this->assertSame(
$response['content'],
$expected
); this must me like this $this->assertSame(
$expected,
$response['content']
); to just easy to read the fail test with |
missing some value when using costume serializer
the what is better approch to add this, because mine it is set on my presenter using https://github.com/andersao/l5-repository to solve resource key name, |
God effort in adding some kind of description (the config block), but please add a better one. I'm not very familiar with that part of the code, and It helps to know what I'm looking for before I review the changes. |
…nerator into custom-serializer
Signed-off-by: Lloric Mayuga Garcia <lloricode@gmail.com>
this will dynamically generate format result by custom serializer from league/fractal, it can be null ass default behavior.