Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix domain name for the generated links #458

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Fix domain name for the generated links #458

merged 1 commit into from
Feb 12, 2019

Conversation

Sh1d0w
Copy link
Contributor

@Sh1d0w Sh1d0w commented Feb 10, 2019

There is a bug, that if you've set your APP_URL to something different than localhost (e.g. using valet), all documentation and Postman links, including the link to the Postman collection will be generated with localhost as domain name.

This PR forces Laravel to use the domain name set in your configuration in order to generate the links correctly.

@codecov-io
Copy link

codecov-io commented Feb 10, 2019

Codecov Report

Merging #458 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #458      +/-   ##
============================================
+ Coverage     92.22%   92.23%   +0.01%     
  Complexity      239      239              
============================================
  Files            12       12              
  Lines           566      567       +1     
============================================
+ Hits            522      523       +1     
  Misses           44       44
Impacted Files Coverage Δ Complexity Δ
src/Commands/GenerateDocumentation.php 95% <100%> (+0.04%) 40 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e98c7f4...d915818. Read the comment docs.

@shalvah shalvah merged commit b9e5bdc into mpociot:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants