Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore scalar type hints when checking for FormRequests #474

Merged
merged 2 commits into from
Mar 13, 2019

Conversation

usknot
Copy link

@usknot usknot commented Mar 11, 2019

If a ReflectionException occurs, set it to continue.

@codecov-io
Copy link

codecov-io commented Mar 11, 2019

Codecov Report

Merging #474 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #474      +/-   ##
============================================
+ Coverage     92.45%   92.47%   +0.02%     
- Complexity      247      248       +1     
============================================
  Files            12       12              
  Lines           583      585       +2     
============================================
+ Hits            539      541       +2     
  Misses           44       44
Impacted Files Coverage Δ Complexity Δ
src/Tools/Generator.php 95.09% <100%> (+0.06%) 71 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61dc0fb...cf5f422. Read the comment docs.

@usknot usknot mentioned this pull request Mar 11, 2019
@shalvah shalvah merged commit 4560c86 into mpociot:master Mar 13, 2019
@shalvah shalvah changed the title fix: Correspondence of ReflectionException of version 3.4.0 Ignore scalar type hints when checking for FormRequests Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants