Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to base_url config var for base URL in docs and collection #523

Merged
merged 4 commits into from
Jun 8, 2019

Conversation

shalvah
Copy link
Contributor

@shalvah shalvah commented Jun 8, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 8, 2019

Codecov Report

Merging #523 into master will increase coverage by 1.03%.
The diff coverage is 88.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #523      +/-   ##
============================================
+ Coverage     92.54%   93.58%   +1.03%     
- Complexity      279      372      +93     
============================================
  Files            13       14       +1     
  Lines           644      779     +135     
============================================
+ Hits            596      729     +133     
- Misses           48       50       +2
Impacted Files Coverage Δ Complexity Δ
src/Tools/Generator.php 97.58% <100%> (+1.88%) 142 <2> (+57) ⬆️
.../Tools/ResponseStrategies/ResponseCallStrategy.php 94.06% <100%> (+0.05%) 40 <0> (ø) ⬇️
src/Tools/DocumentationConfig.php 100% <100%> (ø) 2 <2> (?)
src/Postman/CollectionWriter.php 81.25% <50%> (-8.04%) 18 <1> (+1)
src/Commands/GenerateDocumentation.php 94.73% <94.11%> (+1.6%) 74 <0> (+30) ⬆️
src/Tools/Utils.php 100% <0%> (ø) 13% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc16f27...c127319. Read the comment docs.

@shalvah shalvah merged commit 3417131 into master Jun 8, 2019
@shalvah
Copy link
Contributor Author

shalvah commented Jun 8, 2019

Closes #520

@shalvah shalvah deleted the update-config branch June 8, 2019 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants