Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge groups in documentation #556

Merged
merged 13 commits into from
Aug 25, 2019
Merged

Merge groups in documentation #556

merged 13 commits into from
Aug 25, 2019

Conversation

shalvah
Copy link
Contributor

@shalvah shalvah commented Aug 25, 2019

This PR fixes #535 by splitting the @group tag content into a groupName and groupDescription. The group title alone is used as the heading, and the first non-empty group description is picked from the routes in that group.

Also included: propagating verbosity level down to Collision library, updated Dingo version, removed callable route syntax test for Dingo since Dingo doesn't support it.

@codecov-io
Copy link

codecov-io commented Aug 25, 2019

Codecov Report

Merging #556 into master will decrease coverage by 0.59%.
The diff coverage is 84.21%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #556     +/-   ##
===========================================
- Coverage     90.89%   90.29%   -0.6%     
  Complexity      290      290             
===========================================
  Files            14       14             
  Lines           692      701      +9     
===========================================
+ Hits            629      633      +4     
- Misses           63       68      +5
Impacted Files Coverage Δ Complexity Δ
src/Tools/Utils.php 71.42% <0%> (-2.11%) 13 <2> (ø)
src/Tools/Generator.php 95.87% <100%> (+0.17%) 86 <0> (ø) ⬇️
src/Commands/GenerateDocumentation.php 94.11% <100%> (ø) 44 <1> (ø) ⬇️
.../Tools/ResponseStrategies/ResponseCallStrategy.php 87.6% <0%> (-3.31%) 41% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f691f9e...54dc2aa. Read the comment docs.

@shalvah shalvah merged commit 3f418d6 into master Aug 25, 2019
@shalvah shalvah deleted the merge-groups branch October 18, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge groups in documentation
3 participants