Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third mouse click breaks 'cycle fullscreen', often leading to bugged window state after dragging. #12214

Closed
Sneakpeakcss opened this issue Aug 21, 2023 · 1 comment · Fixed by #13003
Labels

Comments

@Sneakpeakcss
Copy link

Sneakpeakcss commented Aug 21, 2023

Important Information

 

For some reason the third mouse click is recognised as another MBTN_Left_DBL action, leading to additional execution of fullscreen, there's around 250ms delay between clicks where it can happen.
Beyond the annoyance of unwanted action, it very often leads to another old bug #1921 when the player is cycled from fullscreen, and then quickly dragged, leading to a lot of window glitching. This behaviour is so consistent that it breaks MBTN_Left_DBL cycle fullscreen in a workflow that requires to constantly switch and move videos.

Reproduction steps

  1. Quickly press LMB 3 times.
  2. Do the same as above from a fullscreen state, and instantly try dragging the window.

Expected behavior

Third mouse click shouldn't toggle Fullscreen action.

Actual behavior

mpv.mp4

00:00 - Examples of 3rd click cycling fullscreen.
00:06 - Examples of 3rd click going back to fullscreen and locking the window in a 'fullscreen windowed' state that breaks dragging (the mentioned old bug).

Log file

mpvlog.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants