-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osc.lua: add idlescreen and osc-idlescreen #10207
Conversation
e814280
to
ee30f51
Compare
I've changed it so only one option ( |
I tested it by changing mpv.net and the osm script accordingly, it works fine, thank you. |
I think it would be helpful for scripts writing the osc-idlelogo state to shared-script-properties, much like osc-visibility is written to shared-script-properties. This would allow scripts to temporarily change the state and afterwards restore it. Restoring it, at least for me, is not important, but would still be nice if it could be done. In my osm script, before I show my menu, I do this:
https://github.com/stax76/mpv-scripts/blob/main/osm.lua#L101 |
It now does this. |
Code lgtm but the commit message is missing a colon |
29796b4
to
4a58f75
Compare
Thanks, I'm looking forward to this getting merged. |
I'm thinking about instead making the ASS text in here configurable so you could just pass an empty string (i.e. no logo). It would be more flexible. The implementation is a little trickier though because the logo is technically multiple strings not one so it would not be as simple as a typical string conf option. |
Decided to ax this idea. I renamed this to |
This is mainly for other user scripts that may conflict with the osc logo in some way. Although it is possible to listen for shared-script-properties, this has many edge cases that could easily pop up. A user could want other OSC things to happen at the same time (say osc-message). They just don't want the logo. The idlescreen option disables all idlescreen related things (including the santa hat) if it is set to "no". A new script message (osc-idlescreen) is also added so users can easily toggle the value (passing "cycle" or just explictly setting "yes" or "no"). Some more discussion on this is found in the below github issues. mpv-player#10201 CogentRedTester/mpv-file-browser#55
This is mainly for other user scripts that may conflict with the osc
logo in some way. While you can use script-message and
shared-script-properties (highly discouraged in the documentation for
some reason) to work around this, there's still some brittle edge cases
and complicated logic that can pop up. Adding an option for these two
things (the logo and the "drop files..." text) is really trivial and
would make things easier for scripts. Discussed in a couple of issues
below:
#10201
CogentRedTester/mpv-file-browser#55