-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
player: set default cache dir on macOS #11939
Conversation
i totally don't see a reason to use any env variables completely specific to linux and have nothing to do with any specifications of macOS. we rejected such changes previously. either we do it properly and migrate all paths to macOS conventions, which in return will raise the ire of one group of mac users, or do it completely as linux, which will raise the ire of the other group. either we don't change anything or do it properly the macOS way. a half assed middle way is imo something we should not desire. personally i always wanted to change everything to the macOS standard ways but was also stopped back in the days. changing everything also might have the side effect of breaking all existing configs/setups. |
Yeah I dunno about the environment variables and if anyone actually uses them on macOS. I don't think adding at least a cache directory hurts. I don't think anybody wants cache in their config (and it wasn't there before). |
@Akemi Hmm. If we choose to fully switch to macOS conventions, how the paths should look like? Maybe something like this: Or just implement only cache dir for now like @Dudemanguy suggested? |
I've removed env variables (except config one which was there before) and set ~~cache to |
@Akemi @Dudemanguy I've updated the doc. Please, let me know if it's ok to go with only cache dir change. This shouldn't harm users and allow us to implement other macOS-specific dirs in future. |
Use ~/Library/Caches/io.mpv for caches instead of ~~home.
@Dudemanguy updated, thank you :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @Akemi is this sensible to you?
if we ever do this this seems okay.
yes this is very reasonable. the cache files shouldn't be in the config dir at all. just mentioning it, i don't have a working mac right now and can't test anything. so this would need merging without testing from my side. |
@m154k1: Thanks for taking care of this! |
Since shader/icc caches are enabled by default now
~/.config/mpv
may contain a lot of cache files on macOS. Most likely, users want to have only configuration files here so change default cache path to macOS specific directory.