Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input.conf: bind left click to cycle pause #15405

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

guidocella
Copy link
Contributor

a6683ea and 639ef09 made it possible to bind MBTN_LEFT without conflicting with dragging, so since cycling pause on left click is common in video players, bind it.

Copy link

github-actions bot commented Nov 29, 2024

Download the artifacts for this pull request:

Windows
macOS

@na-na-hi
Copy link
Contributor

This is not a good default when border/titlebar is disabled, or becomes invisible at fullscreen, because it cycles pause when you just want to click to raise/focus it. MPC-HC has the same problem in minimal layouts.

I tried this after I implemented dragging deadzone but was annoyed by this behavior that I only kept this if the window manager has focus follow mouse enabled.

@kasper93
Copy link
Contributor

kasper93 commented Nov 29, 2024

This is not a good default when border/titlebar is disabled, or becomes invisible at fullscreen, because it cycles pause when you just want to click to raise/focus it. MPC-HC has the same problem in minimal layouts.

I tried this after I implemented dragging deadzone but was annoyed by this behavior that I only kept this if the window manager has focus follow mouse enabled.

I agree with this. This is probably the main reason I don't have it bound to LMB either. However, you can focus with any other mouse button as well, so depending on your configuration, it can be avoided. Another issue arises with scripts that bind actions to the left mouse button, in case you to miss the clickable zone.

I think pause is one of the main commands, so it makes sense to bind it to the primary action button on the mouse. However, it's probably not something everyone prefers.

One thing I would like is to have the context menu / select.lua functionality bound to RMB, which is currently occupied by pause.

It would be useful for touch interfaces to pause on tap, though. For touch, it would also make sense to implement touch zones to make some commands more accessible, like pause/play, next/previous, volume up/down, and so on. But that's a separate topic.

EDIT:

For touch the focus problem also exists, so maybe it should trigger only when mpv is focused.

a6683ea and 639ef09 made it possible to bind MBTN_LEFT without
conflicting with dragging, so since cycling pause on left click is
common in video players, and MBTN_RIGHT can be freed to implemnet a menu
later, bind it.
@verygoodlee
Copy link
Contributor

Another problem is that double left-click cycle fullscreen triggers cycle pause twice, which can only be solved by third-party scripts at the moment.
https://github.com/natural-harmonia-gropius/input-event?tab=readme-ov-file#click-to-pause-double-click-to-fullscreen

@paulguy
Copy link

paulguy commented Nov 29, 2024

I like right click toggling pause and left click set in input.conf to set pause no so it's just a way to always unpause and otherwise do nothing. I use a window manager hotkey to grab the borderless window.

@Akemi
Copy link
Member

Akemi commented Nov 29, 2024

personally i am not in favour of binding left click to toggling pause.

though if the goal is to free right click in the long run, like for a 'context menu' (imo right click should probably be a context menu, since that's widely expected anywhere), maybe middle click would be a good alternative.

though changing the default for right clicking will most likely be a painful discussion. personally i am also a bit conflicted about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants