Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileContainer: "filename" to "path" and Index #113

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

mathause
Copy link
Collaborator

Renames the "filename" column of FileContainer to "path" and makes it a pd.Index. The biggest work was actually to fix the tests. It also adds some new tests for the FileContainer.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.28%. Comparing base (5f38744) to head (493dd1d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
filefinder/_filefinder.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   88.85%   96.28%   +7.43%     
==========================================
  Files           5        5              
  Lines         296      296              
==========================================
+ Hits          263      285      +22     
+ Misses         33       11      -22     
Flag Coverage Δ
unittests 96.28% <90.00%> (+7.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathause
Copy link
Collaborator Author

@veni-vidi-vici-dormivi if you want to have a look - otherwise it's also ok for me

@mathause
Copy link
Collaborator Author

Thanks 🤗

@mathause mathause merged commit 2d8d836 into main Oct 16, 2024
6 checks passed
@mathause mathause deleted the fc_rename_filename_to_path branch October 16, 2024 19:00
@mathause mathause mentioned this pull request Oct 16, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants