Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mark axios as external dependency in rollup config #61

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

joaolrpm
Copy link
Contributor

Fixes #60 UMD bundling issues.

I have updated the Rollup configuration to mark axios as an external dependency. This change was necessary to address unresolved dependencies and export errors related to axios when bundling the library.

By identifying axios as an external dependency, we prevent it from being bundled with this library. This not only reduces the overall bundle size but also mitigates potential conflicts that may arise when different versions of axios are utilized in the same application.

Please be aware that consumers of this library will need to have axios installed in their project.

@mpyw mpyw merged commit ae3c855 into mpyw:master Jan 17, 2024
6 checks passed
@joaolrpm joaolrpm deleted the fix/umd-build-axios-issue branch January 17, 2024 13:41
@joaolrpm
Copy link
Contributor Author

Hi @mpyw 👋!

I apologize once again for the inconvenience 🙏 Could you please commit the version bump in the package.json to master? The last release couldn't be published because it attempted to publish the changes as version 1.1.0.

@mpyw
Copy link
Owner

mpyw commented Jan 18, 2024

Deleted old incomlete tags to release as 1.1.1 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants