-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(electron): detect electron context #1856
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does somebody got an idea why the commit message is not compliant? Edit: Oh it was the PR title! |
axi92
changed the title
fix(electron): Detect electron context
fix(electron): detect electron context
May 2, 2024
robertsLando
requested changes
May 2, 2024
robertsLando
requested changes
May 2, 2024
robertsLando
requested changes
May 2, 2024
Co-authored-by: Daniel Lando <daniel.sorridi@gmail.com>
@axi92 fix lint issues |
robertsLando
approved these changes
May 2, 2024
browser environment check #1877 |
This was referenced Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the electron context without context isolation all protocols work like in node.
This is tested in the main as well as in the render context.
This PR evolved from that discussion: #1854 (comment)