Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): detect electron context #1856

Merged
merged 7 commits into from
May 6, 2024
Merged

fix(electron): detect electron context #1856

merged 7 commits into from
May 6, 2024

Conversation

axi92
Copy link
Contributor

@axi92 axi92 commented May 1, 2024

In the electron context without context isolation all protocols work like in node.
This is tested in the main as well as in the render context.

This PR evolved from that discussion: #1854 (comment)

@axi92
Copy link
Contributor Author

axi92 commented May 2, 2024

Does somebody got an idea why the commit message is not compliant?
It does follow this schema: https://www.conventionalcommits.org/en/v1.0.0/#commit-message-with-scope
Or did I miss something?

Edit: Oh it was the PR title!

@axi92 axi92 changed the title Detect electron context fix(electron): Detect electron context May 2, 2024
@axi92 axi92 changed the title fix(electron): Detect electron context fix(electron): detect electron context May 2, 2024
src/lib/is-browser.ts Outdated Show resolved Hide resolved
src/lib/is-browser.ts Outdated Show resolved Hide resolved
src/lib/is-browser.ts Outdated Show resolved Hide resolved
Co-authored-by: Daniel Lando <daniel.sorridi@gmail.com>
@robertsLando
Copy link
Member

robertsLando commented May 2, 2024

@axi92 fix lint issues npm run lint-fix and there is also a typo I think in my suggestion

@axi92 axi92 requested a review from robertsLando May 2, 2024 09:16
@robertsLando robertsLando merged commit 6a03d29 into mqttjs:main May 6, 2024
4 checks passed
@axi92 axi92 deleted the feature/electron-context branch May 6, 2024 14:11
@GuoSirius
Copy link

browser environment check #1877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants