Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add quic support #1298

Closed
wants to merge 4 commits into from
Closed

Conversation

agilan2001
Copy link

Added support for QUIC protocol through the core QUIC module of NodeJS (v15 - pre)

NodeJS QUIC Documentation

@agilan2001 agilan2001 closed this Jul 1, 2021
@agilan2001 agilan2001 deleted the add-quic-support branch July 1, 2021 10:42
@agilan2001 agilan2001 restored the add-quic-support branch July 1, 2021 10:45
@agilan2001
Copy link
Author

Added support for QUIC protocol through the core QUIC module of NodeJS (v15 - pre)

NodeJS QUIC Documentation

@agilan2001 agilan2001 reopened this Jul 1, 2021
@YoDaMa
Copy link
Contributor

YoDaMa commented Dec 13, 2021

Thanks for this PR @agilan2001. There is no testing provided.... or samples...

@YoDaMa
Copy link
Contributor

YoDaMa commented Dec 16, 2021

@agilan2001 also please advise how you want to go about supporting this. Since it is an experimental feature in v15, we cannot just say "we support this feature". Is there a way to mark a feature as experimental in the API?

@ysfscream
Copy link
Contributor

ysfscream commented Mar 3, 2023

@agilan2001 Hi, I am so happy and excited to see your PR!

Because the EMQX already supports MQTT over QUIC, see: https://www.emqx.com/en/blog/getting-started-with-mqtt-over-quic-from-scratch
We want to support connections on the client side as well, but Node.js doesn't seem to support it anymore, so I'm very excited to see your PR, so could you please help me how to implement and use it in MQTT.js? I'm currently using it with some errors: it doesn't seem to introduce the module related to QUIC.

image

@agilan2001
Copy link
Author

agilan2001 commented Mar 4, 2023

@ysfscream QUIC support was present in NodeJS only in v15.x.
This would work only in the manually built NodeJS-v15.x binary with --experimental-quic flag enabled.

Compiled NodeJS binaries with QUIC support could be found here:
https://github.com/agilan2001/mqtt-project/tree/master/node_v15

[QUIC Support in the core package could be tracked in the open PR : https://github.com/nodejs/node/pull/44325]

@ysfscream
Copy link
Contributor

ysfscream commented Mar 8, 2023

@agilan2001 Thanks very much. Hope to support it quickly and well.

@robertsLando
Copy link
Member

@agilan2001 Can you add a test for this?

@robertsLando robertsLando changed the title Add quic support feat: add quic support Jun 27, 2023
@robertsLando
Copy link
Member

robertsLando commented Jun 29, 2023

If you wish to continue with this PR please remember to change destination branch from master to main 🙏🏼

robertsLando added a commit that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants