Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): close open connections #1911

Merged
merged 9 commits into from
Aug 1, 2024
Merged

fix(test): close open connections #1911

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e9702d2
fix: tets hang up
MaximoLiberata Jul 19, 2024
f44744e
Merge branch 'mqttjs:main' into improve-tests
MaximoLiberata Jul 26, 2024
a141420
fix(test): close open connections
MaximoLiberata Jul 26, 2024
19e6c3f
test: catch error
MaximoLiberata Jul 26, 2024
25da706
feat: move clean_method class to help
MaximoLiberata Jul 31, 2024
54a56ac
fix: hang tests
MaximoLiberata Jul 31, 2024
72add25
fix: lint style
MaximoLiberata Jul 31, 2024
0290cda
fix: teardown helper functionality
robertsLando Aug 1, 2024
7ae2764
docs: change examples according new changes
MaximoLiberata Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/lib/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,10 @@ export type OnMessageCallback = (
export type OnPacketCallback = (packet: Packet) => void
export type OnCloseCallback = () => void
export type OnErrorCallback = (error: Error | ErrorWithReasonCode) => void
export type PacketCallback = (error?: Error, packet?: Packet) => any
export type PacketCallback = (
error?: Error | ErrorWithReasonCode,
packet?: Packet,
) => any
export type CloseCallback = (error?: Error) => void

export interface MqttClientEventCallbacks {
Expand Down
14 changes: 9 additions & 5 deletions src/lib/handlers/ack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Other Socket Errors: EADDRINUSE, ECONNRESET, ENOTFOUND, ETIMEDOUT.

import { PacketHandler } from '../shared'
import { PacketHandler, ErrorWithReasonCode } from '../shared'

export const ReasonCodes = {
0: '',
Expand Down Expand Up @@ -82,8 +82,10 @@ const handleAck: PacketHandler = (client, packet) => {
const pubackRC = packet.reasonCode
// Callback - we're done
if (pubackRC && pubackRC > 0 && pubackRC !== 16) {
err = new Error(`Publish error: ${ReasonCodes[pubackRC]}`)
err.code = pubackRC
err = new ErrorWithReasonCode(
`Publish error: ${ReasonCodes[pubackRC]}`,
pubackRC,
)
client['_removeOutgoingAndStoreMessage'](messageId, () => {
cb(err, packet)
})
Expand All @@ -102,8 +104,10 @@ const handleAck: PacketHandler = (client, packet) => {
const pubrecRC = packet.reasonCode

if (pubrecRC && pubrecRC > 0 && pubrecRC !== 16) {
err = new Error(`Publish error: ${ReasonCodes[pubrecRC]}`)
err.code = pubrecRC
err = new ErrorWithReasonCode(
`Publish error: ${ReasonCodes[pubrecRC]}`,
pubrecRC,
)
client['_removeOutgoingAndStoreMessage'](messageId, () => {
cb(err, packet)
})
Expand Down
Loading