Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add unsubscribe ack packet to the unsubscribe callback #1922

Merged
merged 3 commits into from
Aug 5, 2024
Merged

feat: add unsubscribe ack packet to the unsubscribe callback #1922

merged 3 commits into from
Aug 5, 2024

Conversation

bretambrose
Copy link
Contributor

@bretambrose bretambrose commented Aug 2, 2024 •
edited by robertsLando
Loading

Fixes #1512

@bretambrose bretambrose changed the title bug: Invoke the unsubscribe ack callback with the Unsuback packet, not null fix: Invoke the unsubscribe ack callback with the Unsuback packet, not null Aug 2, 2024
@bretambrose bretambrose changed the title fix: Invoke the unsubscribe ack callback with the Unsuback packet, not null fix: Invoke the unsubscribe ack callback with the Unsuback packet, not undefined Aug 2, 2024
@robertsLando robertsLando changed the title fix: Invoke the unsubscribe ack callback with the Unsuback packet, not undefined feat: add unsubscribe ack packet to the unsubscribe callback Aug 5, 2024
robertsLando
robertsLando approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@robertsLando robertsLando left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsLando robertsLando merged commit 8bcf304 into mqttjs:main Aug 5, 2024
6 checks passed
@madhavilosetty-intel madhavilosetty-intel mentioned this pull request Sep 4, 2024
Closed
@matt-primrose matt-primrose mentioned this pull request Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertsLando robertsLando robertsLando approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unsuback user callback is invoked with no context
2 participants
@bretambrose @robertsLando