-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(electron-test): move third hosted broker to self hosted broker #1926
feat(electron-test): move third hosted broker to self hosted broker #1926
Conversation
@axi92 Could you review this PR, too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I higly suggest to use aedes-cli instead:
MQTT.js/web-test-runner.config.mjs
Lines 8 to 16 in 2f8e739
await start({ | |
protos: ['tcp', 'tls', 'ws', 'wss'], | |
wsPort, | |
wssPort, | |
key: './test/certs/server-key.pem', | |
cert: './test/certs/server-cert.pem', | |
verbose: true, | |
stats: false | |
}) |
@robertsLando I have a question, the Is there a way to close |
@MaximoLiberata https://github.com/moscajs/aedes-cli/blob/master/lib/cli.js#L420 |
Thanks @robertsLando |
@MaximoLiberata Sorry for the late review but I'm on holiday, I will be back on the end of August :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just came back from holidays, sorry for the late review! Everything looks good to me, just remove the useless option and I will merge this, thanks 🙏🏼
thanks @robertsLando and @axi92 for review 🙏🏼 |
electron tests may present connection issues when try to connect to third hosted broker. The tests will fail for external issues not related to MQTT.JS. A self hosted broker will mitigate these issues.