add support for weapp

[taoqf]

For now, if using with webpack, need wait for browserify/timers-browserify#24 and max-mapper/websocket-stream#129 merged.

[mcollina]

I'm a bit lost in what is weapp, wx and such.

[taoqf]

https://mp.weixin.qq.com/cgi-bin/wx
I have added something to the readme,but tests could not be added because it's only could run in container.

[codecov]

Codecov Report

Merging #653 into master will decrease coverage by 3.48%.
The diff coverage is 79.04%.

@@            Coverage Diff             @@
##           master     #653      +/-   ##
==========================================
- Coverage   93.22%   89.73%   -3.49%     
==========================================
  Files           8        9       +1     
  Lines         664      760      +96     
  Branches      160      198      +38     
==========================================
+ Hits          619      682      +63     
- Misses         45       78      +33

Impacted Files	Coverage Δ
lib/connect/wx.js	55.38% <55.38%> (ø)
lib/connect/index.js	94.17% <94.11%> (-3.05%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5afa5ac...83e8037. Read the comment docs.

[taoqf]

@mcollina What can I do with the failled checks?

[taoqf]

@mcollina Weixin(wx) is an application runs on android, iPhone, you may think it as cordova, It allow h5 application(we call it weapp sometime) runs in it, and it allow users to use WebSocket using it's api.

[mcollina]

I'm not landing code without unit test. So, we should change the approach:

how about we add support so that you can specificy a custom protocol? That would probably help.

Also, why lib/connect/index.js look all rewritten? Maybe spacing?

[taoqf]

Then could I add some unit test with failing judge? I think there are so many chinese programmer would need this.

[mcollina]

why this?

[taoqf]

it was defined multi times. see line 4

[mcollina]

Unit tests will be good?

[taoqf]

I don't know how to add unit test yet, but I would try my best.

[taoqf]

I have done some test, not unit test, it works good.

[taoqf]

@mcollina so need I add unit test for this pr?

[mcollina]

Yes.

[taoqf]

Hi, @mcollina , I have add some test into /test/wx.js and passed npm run weapp-test.
is this the right way to add unit test?

[taoqf]

Whatever I try, still could pass codecov check. any help?

[mcollina]

I'll merge this. However, can you please restore lib/connect/index.js to what is there on master? It's all reported as changed in this PR.

[mcollina]

we should not be adding wx if it's not a browser. the main wx object is not there.

[taoqf]

@mcollina , Thanks, I move the code into else block, and I skiped the unit tests I added because it could not be running on node.js.

[mcollina]

You can remove the skipped tests.

What have you changed to the lib/connect/index.js file? GH reports it was all changed, but it does not seems so. Can you please restore it to what was before and apply only your modifications?

[taoqf]

I tried not skip the tests and it will cause a failing test after that test.

189 passing (18s)
  1 failing

  1) MqttSecureClient pinging should reconnect if pingresp is not sent:
     Uncaught Error: connect ECONNREFUSED 127.0.0.1:8883
      at Object.exports._errnoException (util.js:1024:11)
      at exports._exceptionWithHostPort (util.js:1047:20)
      at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1150:14)

I don't really know what was wrong with github, I had not changed the whole file connect/index.js.
I will try to create a new pr later and see if gh reports the same.

[vikingsailor]

@taoqf 在微信小程序里怎么使用mqtt连接AZURE?我已经在nodejs中联通了iot云，但是想在小程序中看到各设备的消息？如何实现？

[taoqf]

Could you please describe azure?