remove unused, undocumented "disconnected" property from MqttClient #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing on CI, are they related? |
|
don’t believe so; I’m experiencing a lot of random flake running the tests. |
|
I think a proper finite state machine might be a good idea. |
|
Definitely. |
|
I'm gonna withdraw this then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While probing around for the root cause of another bug, I discovered the
disconnectedproperty, which is incongruous with the documentedconnected, and also seemingly unnecessary.Prior to this change, situation arises where the
connectedproperty istrueeven if a call toend()has completed, which seems incorrect. This may be the source of my bug, but haven't tested yet 😄The changes below don't seem to affect the test outcomes, since the
disconnectedproperty is not referenced anywhere other than the two places seen in this diff.