Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reactions enum #144

Merged
merged 4 commits into from
Mar 12, 2024
Merged

add reactions enum #144

merged 4 commits into from
Mar 12, 2024

Conversation

mr-linch
Copy link
Owner

No description provided.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.71%. Comparing base (5cf133d) to head (56313ab).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   94.61%   94.71%   +0.10%     
==========================================
  Files          21       22       +1     
  Lines        2320     2327       +7     
==========================================
+ Hits         2195     2204       +9     
+ Misses         85       84       -1     
+ Partials       40       39       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mr-linch - I've reviewed your changes and they look great!

General suggestions:

  • Consider implementing context-aware filtering for emoji reactions to ensure appropriateness and relevance.
  • Logging occurrences where users attempt to use the 'react' command without replying to a message could be beneficial for debugging and usage tracking.
  • Ensure that the emojis used are universally supported across all platforms to avoid display issues.
  • The addition of helper functions for creating reaction types is a good practice for code maintainability and ease of adding new reactions in the future.
Here's what I looked at during the review
  • 🟡 General issues: 4 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

examples/echo-bot/main.go Show resolved Hide resolved
reactions.go Outdated Show resolved Hide resolved
types_gen_ext.go Outdated Show resolved Hide resolved
@mr-linch mr-linch merged commit 8764513 into main Mar 12, 2024
5 checks passed
@mr-linch mr-linch deleted the reactions-enum branch March 12, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant