Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from zellij-org:main #44

Merged
merged 2 commits into from
Dec 26, 2024
Merged

[pull] main from zellij-org:main #44

merged 2 commits into from
Dec 26, 2024

Conversation

pull[bot]
Copy link

@pull pull bot commented Dec 26, 2024

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Bug Fixes:

  • Fix an issue where the synchronized rendering detection query response was incorrect.

darrenburns and others added 2 commits December 26, 2024 10:22
The response to the 2026 mode query was missing a `?` character.

The response should be of the format `CSI ? 2026 ; N $ y` where N can
be any value in the range 0-4 inclusive.

References:

https://gist.github.com/christianparpart/d8a62cc1ab659194337d73e399004036
https://vt100.net/docs/vt510-rm/DECRPM.html
@pull pull bot added the ⤵️ pull label Dec 26, 2024
@pull pull bot merged commit 2e58ad3 into mr-narender:main Dec 26, 2024
Copy link

sourcery-ai bot commented Dec 26, 2024

Reviewer's Guide by Sourcery

This pull request fixes an issue with synchronized rendering detection in terminals by correcting the query response in zellij-server/src/panes/grid.rs. It also updates the changelog to reflect this change.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Fixed synchronized rendering detection query response
  • Corrected the escape sequence used for querying synchronized rendering support in terminals from \\u{1b}[2026;2$y to \\u{1b}[?2026;2$y.
zellij-server/src/panes/grid.rs
Updated changelog CHANGELOG.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants