Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt weave to non-var destructors #196

Closed
wants to merge 1 commit into from
Closed

adapt weave to non-var destructors #196

wants to merge 1 commit into from

Conversation

ringabout
Copy link
Contributor

@mratsim
Copy link
Owner

mratsim commented Nov 22, 2023 •
edited
Loading

But deinitCond and deinitLock require var, see: https://nim-lang.org/docs/locks.html#deinitCond%2CSysCond

@ringabout
Copy link
Contributor Author

Indeed, I suppose it needs to be defined as ptr Cond or something. Neverthless, it's goint to be put behind a flag and var T destructors will become an error.

@ringabout ringabout closed this Nov 22, 2023
@ringabout ringabout deleted the patch-4 branch November 22, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ringabout @mratsim