Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read config #1

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Read config #1

merged 3 commits into from
Aug 9, 2023

Conversation

richfitz
Copy link
Member

@richfitz richfitz commented Aug 7, 2023

Super simple, just read a config. I've added a small example set of data from R that will bootstrap us for a while.

No support yet (or indeed for a while) for writing a config, or initialising a root - this is more similar to the rust support for a bit.

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (407c734) 100.00% compared to head (761fa37) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #1   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         4    +2     
  Lines           16        70   +54     
  Branches         2        11    +9     
=========================================
+ Hits            16        70   +54     
Files Changed Coverage Δ
src/outpack/config.py 100.00% <100.00%> (ø)
tests/test_config.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richfitz richfitz requested a review from r-ash August 7, 2023 15:59
Copy link
Contributor

@r-ash r-ash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good here, I'd like to get this running on my workstation when I come in later if you can hold off on merge until then? Otherwise I can do it after the fact

@richfitz richfitz merged commit 20d7533 into main Aug 9, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants