Update ruff configuration to fix deprecation warnings. #39
Conversation
ruff has deprecated top-level lint settings, instead they must be moved into a dedicated `lint` section. Additionally, the CLI now needs to be invoked with a `check` subcommand. https://astral.sh/blog/ruff-v0.2.0#configuration-changes astral-sh/ruff#10169
|
Not sure why the windows test is failing here; unrelated to these changes. Is this something that fails sometimes perhaps (e.g., timing difference on windows?) |
|
It seems to be about different ordering when comparing two lists of IDs: https://github.com/mrc-ide/outpack-py/actions/runs/8613882705/job/23606156639#step:5:72 The LHS is always sorted alphabetically (in https://github.com/mrc-ide/outpack-py/blob/5f927d6892c05d3eca18fb559f82f83a88a60866/src/outpack/index.py#L65), the RHS is sorted by order of creation. If the packets are created within the same time fraction (I don't know what the resolution is), these two orders may not be the same. I've re-run the test and it passed now. I'll merge this and fix the issue separately. |
|
Fix in #40 |
ruff has deprecated top-level lint settings, instead they must be moved into a dedicated
lintsection. Additionally, the CLI now needs to be invoked with achecksubcommand.https://astral.sh/blog/ruff-v0.2.0#configuration-changes
astral-sh/ruff#10169