Add support for pulling from http location. #61
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
==========================================
+ Coverage 99.12% 99.23% +0.10%
==========================================
Files 51 55 +4
Lines 4012 4313 +301
Branches 371 285 -86
==========================================
+ Hits 3977 4280 +303
+ Misses 21 18 -3
- Partials 14 15 +1 ☔ View full report in Codecov by Sentry. |
|
Thoughts on just dropping support for 3.8? It was released 5 years ago, and has just hit EOL last month.
|
|
Dropping 3.8 is totally fine |
There was a problem hiding this comment.
Nice - this took me a while to remember how to get everything going, which is itself a problem. I've been poking around with uv but it's alarming that to get going with this one needs to install uv or pipx to install hatch to install the dependencies, which seems wild.
This worked first time for hitting packit, the oauth flow is nice though not quite as slick as httr2's and I get what looks like some debug printed:
Logging in to https://packit.dide.ic.ac.uk/training/
Visit https://github.com/login/device and enter the code <3F72-22EC>
DeviceAuthorizationResponse(device_code='fb462686ed23572ca5f1079c0db99a673391f355', user_code='3F72-22EC', verification_uri='https://github.com/login/device', expires_in=899, interval=5)
Logged in successfully
so somewhere within this range: https://github.com/mrc-ide/pyorderly/blob/mrc-5968/src/pyorderly/outpack/location_packit.py#L175-L187 - but it's not obvious what is causing that.
I recognise a lot of the code from the R version, so let's merge this and iterate on the differences.
Up to you how much of the coverage holes you want to fix or ignore
| @@ -36,6 +37,18 @@ jobs: | |||
| run: | | |||
| python -m pip install --upgrade pip | |||
| pip install hatch | |||
|
|
|||
| # Compiling outpack server from source takes a few minutes each time. | |||
| "sphinx-copybutton", | ||
| "sphinx-autoapi" | ||
| "sphinx-rtd-theme", |
There was a problem hiding this comment.
We really need to get the docs up to spec at some point :(
plietar
force-pushed
the
mrc-5968
branch
3 times, most recently
from
ea346db
to
a37a2d8
Compare
This adds two new location types, "http" and "packit", used to interact with outpack_server and Packit, respectively. The behaviour is based upon the R orderly2 implementation. Authentication to Packit can be done by providing a Packit JWT, a GitHub PAT or interactively using an OAuth device flow against GitHub. For now, tokens obtained through interactive login are only cached in memory. I need to think about where and how tokens may be saved on disk. There is no pushing support yet.
This adds two new location types, "http" and "packit", used to interact with outpack_server and Packit, respectively. The behaviour is based upon the R orderly2 implementation.
Authentication to Packit can be done by providing a Packit JWT, a GitHub PAT or interactively using an OAuth device flow against GitHub. For now, tokens obtained through interactive login are only cached in memory. I need to think about where and how tokens may be saved on disk.
There is no pushing support yet.