Skip to content

Commit

Permalink
tipc: add NULL pointer check
Browse files Browse the repository at this point in the history
skb somehow dequeued out of inputq before processing, it causes to
NULL pointer and kernel crashed.

Add checking skb valid before using.

Fixes: c55c8ed ("tipc: smooth change between replicast and broadcast")
Reported-by: Tuong Lien Tong <tuong.t.lien@dektech.com.au>
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: Hoang Le <hoang.h.le@dektech.com.au>
Acked-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Hoang Le authored and davem330 committed Apr 5, 2019
1 parent 95e27a4 commit e1279ff
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions net/tipc/bcast.c
Original file line number Diff line number Diff line change
Expand Up @@ -769,6 +769,9 @@ void tipc_mcast_filter_msg(struct net *net, struct sk_buff_head *defq,
u32 node, port;

skb = skb_peek(inputq);
if (!skb)
return;

hdr = buf_msg(skb);

if (likely(!msg_is_syn(hdr) && skb_queue_empty(defq)))
Expand Down

0 comments on commit e1279ff

Please sign in to comment.