variable size to fixed 30

mrchypark · Apr 17, 2022 · a070219 · a070219
1 parent d968924
commit a070219
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 8 deletions.
diff --git a/.Rbuildignore b/.Rbuildignore
@@ -23,3 +23,4 @@ kiwilibs/*
 ^pkgdown/*
 ^vignettes/*
 ^CRAN-SUBMISSION$
+^cran-comments\.md$
diff --git a/CRAN-SUBMISSION b/CRAN-SUBMISSION
@@ -1,3 +1,3 @@
-Version: 0.2.1
-Date: 2022-04-16 04:53:52 UTC
-SHA: fd9c6cff290d0dc088b0cd6e01a6f1cf3c4a8044
+Version: 0.2.2
+Date: 2022-04-17 04:35:54 UTC
+SHA: d968924909a601a7ecc844408fe0defa58957352
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,7 @@
 # elbird 0.2.2
 
+* size to 30 for [-Wvla]
+
 # elbird 0.2.1
 
 * Add `Stopwords` `add()` method form param default value NA.

diff --git a/R/kiwi.R b/R/kiwi.R
@@ -1,4 +1,4 @@
-#' Kiwi class
+#' Kiwi Class
 #'
 #' @description
 #'   Kiwi class is provide method for korean mophological analyze result.

diff --git a/cran-comments.md b/cran-comments.md
@@ -0,0 +1,5 @@
+## R CMD check results
+
+0 errors | 0 warnings | 1 note
+
+* Fix [-Wvla] warninng on 0.2.1
diff --git a/man/Kiwi.Rd b/man/Kiwi.Rd
diff --git a/src/kiwi_bind.cpp b/src/kiwi_bind.cpp
@@ -188,9 +188,9 @@ int kiwi_builder_add_pre_analyzed_word_(
   cpp11::integers start = analyzed_r["start"];
   cpp11::integers end = analyzed_r["end"];
 
-  const char* analyzed_morphs[size];
-  const char* analyzed_pos[size];
-  int positions[size*2+1];
+  const char* analyzed_morphs[30];
+  const char* analyzed_pos[30];
+  int positions[61];
 
   for (int i = 0; i < size; ++i) {
     analyzed_morphs[i] = morphs[i].c_str();