Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closure Compiler Failure - Redirect Limit Reached caused by non-ssl access #619

Closed
FritzTGreen opened this issue Nov 3, 2017 · 2 comments

Comments

@FritzTGreen
Copy link

Attempts to use the optional Google Closure Compiler in Minify versions 2 and 3 recently began failing and generating the following PHP Warning log entry:

PHP Warning: file_get_contents(http://closure-compiler.appspot.com/compile): failed to open stream: Redirection limit reached, aborting in /home/xxxxxx/public_html/min/lib/Minify/JS/ClosureCompiler.php on line 182 (line 182 in version 3, and line 87 in version 2)

Google has apparently recently disabled access to the compiler via non-ssl access.

Changing the compiler URL from http://closure-compiler.appspot.com/compile to https://closure-compiler.appspot.com/compile in the min/lib/Minify/JS/ClosureCompiler.php file resolves the issue in both versions.

I can also state that version 3.0.2 did not catch this particular failure and did not automatically revert to the default compiler as intended.

Thanks,
Fritz

@glensc
Copy link
Collaborator

glensc commented Nov 3, 2017

duplicate: #618

@glensc glensc closed this as completed Nov 3, 2017
glensc added a commit that referenced this issue Nov 3, 2017
@AlexisFernandez
Copy link

When I make any change on my closureCompiler.php file the images of my site disappear...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants