Fix issue where minify() would corrupt some characters such as in some environments #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bsp;) in some environments Adding the `u` flag there fixes an issue in my environment (MAMP 4.1.1 with PHP 7.1.5) where `minify()` would corrupt the ` ` character (it would get replaced by the replacement character).
|
This also fixes it for 4-byte unicode characters, like 𠜎 𠜱 𠝹 𠱓. |
|
SGTM. Is this testable? Any thoughts @glensc? |
|
Would be difficult. Was only able to reproduce it using the latest version of MAMP. Assumed it had something to do with the version of PCRE installed (8.38), but tried outside of MAMP using that same PCRE version and it worked fine. Having a difficult time tracking down what the source is. |
|
Just added some more |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the
uflag there fixes an issue in my environment (MAMP 4.1.1 with PHP 7.1.5) whereminify()would corrupt the character (it would get replaced by the replacement character).