Conflict with blackbox extension

[ajansveld]

Turning on the Mercurial blackbox logging extension causes vscode to run its hg status* commands in a tight loop, noticeable by the flashing blue badge on the Source Control icon in the Activity Bar.

The extension writes its log files in the repo's .hg folder, perhaps that triggers this behavior?

*
hg status -C
hg cat <filename> (multiple times)
hg summary -q
hg bookmarks

[ajansveld]

This doesn't seem to be resolved completely, there are still multiple hg cat calls when the blackbox extension is enabled. Not sure if you saw my comment here.

[mrcrowl]

@ajansveld can you provide me with a small repro? I've tried enabling blackbox and can't see the behaviour you're describing.

[ajansveld]

Sure:

• Enable the blackbox extension through the TortoiseHg UI or by setting this in your .hgrc or Mercurial.ini:

[extensions]
blackbox = 

• Open vscode in a local clone, e.g. code C:\temp\test\sandbox\local\
• Open a file in that repo, e.g. abd.txt
• Run the Hg: Show hg output command from the Command Palette
• See the "hg cat abcd.txt" commands scroll by

Closing the file tab will stop the hg cat commands.

Hope this helps,
Arnoud

[ajansveld]

I think this is caused by the blackbox extension creation log files with multiple extensions, e.g.

.hg\.blackbox.log-ji0kbu
.hg\.blackbox.log-ji7eat
.hg\.blackbox.log-msyu4j
.hg\.blackbox.log-wbymm5
.hg\blackbox.log

Suggestion for a fix: change (in src/model.ts)

const isRelevant = !/[\\\/]\.hg[\\\/](\w?lock.*|.*\.log)$/.test(uri.fsPath);

to:

const isRelevant = !/[\\\/]\.hg[\\\/](\w?lock.*|.*\.log(-\w+)?)$/.test(uri.fsPath);

Thanks!

[mrcrowl]

@ajansveld Thanks for investigating further. Could you try installing this version manually?

[ajansveld]

Bummer, 1.1.5 still exhibits the issue. Procmon shows that the blackbox extension writes two more temporary files to .hg (sorry, should have checked this before):

.hg\blackbox.log.hgtmp1
.hg\blackbox.log.hgtmp2

These are not excluded by the suggested code, can you change it to const isRelevant = !/[\\\/]\.hg[\\\/](\w?lock.*|.*\.log([-\.]\w+)?)$/.test(uri.fsPath);?

[mrcrowl]

Bugger! Try this one instead.

[ajansveld]

Winner! Thanks!