Generic VR controller. #10991

stewdio · 2017-03-12T03:50:14Z

Handles gamepad discovery, emits event with controller (Object3D) instance. Handles controller updates for position, orientation (including 3DOF rigs). Watches for updates on axes and button states, emits corresponding events on the controller instance. Good for Vive, Rift, Daydream, and beyond. And all you need to do is include THREE.VRController.update() in your animation loop.

mrdoob · 2017-03-13T19:41:01Z

examples/js/vr/VRController.js

+	controller.dispatchEvent({ type: 'disconnected', controller: controller })
+	delete controller
+}
+window.addEventListener( 'gamepaddisconnected', function( event ){


Hmm... This is sneaky...

For that particular bit I was aiming to follow Mozilla’s guidance here: https://developer.mozilla.org/en-US/docs/Web/API/Gamepad_API/Using_the_Gamepad_API

But instead of removing only the reference to the gamepad I deleted the whole controller. But what makes you say sneaky?

What happens if someone includes VRController.js twice (by mistake)?

Oh—are you talking about the window gamepaddisconnected event? I thought you were pointing out delete controller for some reason. As far as those events go I was (again) trying to follow the convention as seen here: https://developer.mozilla.org/en-US/docs/Web/API/Gamepad_API/Using_the_Gamepad_API

But I see what you mean—despite that feeling like a pretty obscure thing to troubleshoot 😉—it would indeed make those callbacks as many times as VRController.js was included in the document. Fortunately I’m not relying on those events (they’re not supported at all in Chrome right now) so I can strip them out without much fuss.

Ok. I’ve removed the 'ongamepadconnected' and 'ongamepaddisconnected' event listeners.

mrdoob · 2017-03-17T22:06:55Z

examples/webvr_controllers.html

+				torus.rotation.y +=  0.002;
+				if (torus.rotation.y > Math.PI) torus.rotation.y =  torus.rotation.y - (Math.PI * 2);
+
+				controls.update();


Can we add a requestAnimationFrame inside the controls so we don't have to call update from outside? We'll probably have to pass the vrdisplay to the VRController constructor so we can use the correct requestAnimationFrame.

Is your comment about THREE.VRControls? Or about this proposed THREE.VRController? (Both follow the convention of requiring the developer to include a call to .update() in their animation loop.) I chose to follow the existing THREE.VRControls convention because I think this is the cleanest way to do it—rather than having independent rAF loops; makes the sequence of updates more predictable.

mrdoob · 2017-03-17T22:08:07Z

Are let and const really needed? If someone includes this in a browser that doesn't support these yet things will break I think.

mrdoob · 2017-03-17T22:14:24Z

examples/js/vr/VRController.js

+//  Adapted from Boris’ code in a hurry -- many thanks!
+
+const 
+HEAD_ELBOW_OFFSET       = new THREE.Vector3(  0.155, -0.465, -0.15 ),


You're defining these in global space. I think you should wrap all this code in a closure.

You are so correct here—I am embarrassed! It was a quick inclusion job. Will enclose those variables for sure.

Although it’s a bit verbose instead of wrapping it all in a closure, I made these formerly-global variables into properties of OrientationArmModel() because I felt it better expressed their purpose. But what do you think? (That change is in the latest commit around line 581.)

stewdio · 2017-03-21T14:39:41Z

I think using let and const is the right way to go in this specific case. According to these feature support tables there is wider support for them than there is for the Web Gamepad API which we are relying on in this script.

Can I use let? http://caniuse.com/#feat=let
Can I use const? http://caniuse.com/#feat=const
Can I use the Gamepad API? http://caniuse.com/#feat=gamepad

ES6 is at least partially here and I think embracing it as it comes is not a terrible thing ;)

mrdoob · 2017-03-21T23:38:51Z

My argument is that... If the user doesn't have navigator.getGamepads nothing breaks, the page still works. If the user doesn't have ES6 support, JavaScript will stop execution, right?

stewdio · 2017-03-30T18:36:28Z

I see your point. I’ve removed const and let (ES6) in favor of var (ES5).

stewdio · 2017-04-03T15:33:02Z

I think my latest commits have addressed your above concerns—aside from your comment about calling update() in the animation loop; I’d like to better understand your thoughts there.

Once you’re happy with the structure I imagine you’d like me to add semicolons and conform to your whitespace standards? 😉

mrdoob · 2017-04-04T19:30:14Z

Looking good!

Once you’re happy with the structure I imagine you’d like me to add semicolons and conform to your whitespace standards? 😉

Yes, at least semicolons... Never trust the parser 😜

stewdio · 2017-04-06T18:57:49Z

As much as it pained me to do it, I added semicolons just for you 😄

stewdio · 2017-04-12T19:04:47Z

Howdy @mrdoob. Just checking if you had more thoughts on this VRController code 😉

mflux · 2017-04-18T19:13:26Z

@mrdoob ricardo ;) bump

stewdio · 2017-05-04T11:40:18Z

For the time being I’ve posted the code here, including a README:
https://github.com/stewdio/THREE.VRController

But of course I’d love to see this become an official part of r86 😉

marclave · 2017-05-18T22:22:18Z

@mrdoob any updates with this PR? 😄

alexozer · 2017-08-06T17:51:40Z

@mrdoob Any updates?

stewdio · 2017-08-06T18:56:08Z

Now supports r86: https://github.com/stewdio/THREE.VRController

danrossi · 2017-09-09T10:26:47Z

How is this one going ? This seems to work well for me with the Oculus and game controllers.

I was only able to get the trigger buttons working not the top buttons or joystick controls.

However is there an object model that might reflect the game controllers ? I'd like to support the vive controller as well as the GearVR remote.

I was unable to get a laser pointer raycaster working on the object just the menu

The model available in the demo is for the vive controller but the textures are huge.

stewdio · 2017-09-09T11:20:02Z

It’s going really well, but I’m maintaining it here instead:
https://github.com/stewdio/THREE.VRController

The visual models for the various controllers is outside the scope of VRController.

mflux · 2017-09-09T19:13:15Z

I'm surprised @stewdio you didn't mention @djambo's https://github.com/djambo/VRControllerView

stewdio · 2017-09-09T19:53:48Z

AAAAAAHHHH! I didn’t realize that was public yet! My apologies to you and @djambo! I’ll also update VRController’s README to point to VRControllerView. (In-transit right now, but will do it soon.)

EDIT: It’s not public. I emailed @djambo to see if he’d publish it but no response yet.

stewdio · 2017-09-09T19:54:42Z

(And that’s part of why I said it was “out of scope” cause I knew VRControllerView was going to handle it!)

mflux · 2017-09-09T20:03:33Z

To be fair it really needs some documentation on how to use it.

danrossi · 2017-09-10T01:32:35Z

I tried to look for models. aframe include them all but not public. I'm going to fork the project then if required to get Gear VR remote support working.

danrossi · 2017-09-10T01:33:17Z

That project is not live sadly.

stewdio · 2017-10-15T19:13:17Z

Just FYI for whoever ends up in this pull-request thread after Googling... The latest version of VRController now also supports Windows Mixed Reality motion controllers and is available here:
https://github.com/stewdio/THREE.VRController

mrdoob · 2018-01-03T23:21:10Z

Alright. So... how about updating this PR so it sits on top of the WebXR Controllers API? 😇

stewdio · 2018-01-03T23:54:38Z

Yes yes yes!

danrossi · 2018-01-04T09:09:13Z

Is this api available yet ? I see it requires a new api to launch and handle vr devices also.

toji · 2018-01-08T23:06:30Z

For the record we've had our immediate plans for WebXR input derailed by some compatibility concerns with OpenXR. We're working on a solution to that, but in the meantime the Gamepad API will continue to be the way that these devices are accessed.

mrdoob · 2019-11-30T02:58:26Z

Things have changed quite a bit in the last two years...

danrossi · 2019-11-30T05:45:19Z

What are the latest updates ? I implemented my own repository with a working updated gamepad controller to include support for Gear. I'm still waiting for details about WebXR to update to that. Mine works as a laser pointer for virtual video controls.

danrossi · 2019-12-09T10:42:59Z

This has been integrated into the VR and XR manager itself. Ive updated a controls project here to handle those controller events and setup a connect and disconnect event.

https://github.com/danrossi/three-vr-controls

stewdio · 2020-01-03T15:23:16Z

It’s true that things have changed quite a bit over the past ... three years?! (That’s crazy in itself—that it’s been 3 years since I started kicking the tires on this generic VR controller idea in late 2016 / early 2017!)

Looking back, I regret we couldn’t find a way to incorporate these generic VR hand controls in to Three when I offered it here initially. I think it would have benefited the community—and the code itself would have benefited from the community’s constructive input. And that could have driven the official API.

I’ll miss the simplicity and legibility of constructions like this:
controller.addEventListener( 'primary press began', fire )

But mostly I worry we’ve lost little gems like “Multi-channel haptic feedback”:
https://medium.com/@stew_rtsmith/space-rocks-technical-deep-dive-9bf67fb8a467#9a15

Constructions like this made haptics so easy, you’d wonder why anyone was even making a fuss over it in the first place:

controller.setVibe( 'cannon recoil' )
    .set( 0.8 )
    .wait( 20 )
    .set( 0.0 )

controller.setVibe( 'cannon rotation' )
    .set( 0.2 )

Lastly, I feel like I should apologize a bit. I didn’t keep up with VRController much after launching a few projects. I was navigating some personal hurdles that prevented me from giving it enough attention. And I was leaping from job to job chasing the dream of working on web-based virtual reality. (It really amazed me how one could demonstrate through actual launched / delivered projects that WebXR was both feasible and fun and yet time after time I saw support evaporate; groups disbanded. I feel incredibly lucky that I’ve managed to keep getting paychecks for playing with this stuff over the past few years. I don’t take that lightly.)

Anyway, as we roll in to the new decade...
Keep VR weird!

Generic VR controller.

236379e

mrdoob reviewed Mar 13, 2017

View reviewed changes

mrdoob mentioned this pull request Mar 13, 2017

Generic THREE.VRController #10984

Closed

mrdoob reviewed Mar 17, 2017

View reviewed changes

ES6 -> ES5. Moved some vars out of global scope.

a0fab5a

Removed on 'ongamepadconnected' and 'ongamepaddisconnected' listeners.

395bf92

Added semicolons—SAD!

5d17b6a

stewdio added 2 commits April 19, 2017 15:19

Added getButton() to VRController instances.

68e9eec

Updated to r85. Demo code refactored and commented.

1b9e80f

mrdoob added this to the rXX milestone Oct 26, 2018

mrdoob closed this Nov 30, 2019

mrdoob removed this from the rXXX milestone Nov 30, 2019

Generic VR controller. #10991

Generic VR controller. #10991

Conversation

stewdio commented Mar 12, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mrdoob commented Mar 17, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stewdio commented Mar 21, 2017

mrdoob commented Mar 21, 2017

stewdio commented Mar 30, 2017

stewdio commented Apr 3, 2017

mrdoob commented Apr 4, 2017

stewdio commented Apr 6, 2017

stewdio commented Apr 12, 2017

mflux commented Apr 18, 2017

stewdio commented May 4, 2017

marclave commented May 18, 2017

alexozer commented Aug 6, 2017

stewdio commented Aug 6, 2017

danrossi commented Sep 9, 2017

stewdio commented Sep 9, 2017

mflux commented Sep 9, 2017

stewdio commented Sep 9, 2017 • edited Loading

stewdio commented Sep 9, 2017

mflux commented Sep 9, 2017

danrossi commented Sep 10, 2017

danrossi commented Sep 10, 2017

stewdio commented Oct 15, 2017

mrdoob commented Jan 3, 2018

stewdio commented Jan 3, 2018

danrossi commented Jan 4, 2018

toji commented Jan 8, 2018

mrdoob commented Nov 30, 2019

danrossi commented Nov 30, 2019

danrossi commented Dec 9, 2019

stewdio commented Jan 3, 2020

stewdio commented Sep 9, 2017 •

edited

Loading