Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release the reference to the current renderList at the end of .render() #13122

Merged
merged 1 commit into from
Jan 17, 2018
Merged

Release the reference to the current renderList at the end of .render() #13122

merged 1 commit into from
Jan 17, 2018

Conversation

takahirox
Copy link
Collaborator

@takahirox takahirox commented Jan 17, 2018 •
edited
Loading

Even if I dispose renderLists via .dispose() in WebGLRenderer, an element of renderLists referenced by currentRenderList won't be released til next .render() call.

Releasing the reference at the end of .render() fixes this issue.

Or releasing it in .dispose() is another solution.

I implemented the former in this PR so far.

@mrdoob mrdoob merged commit 966aca5 into mrdoob:dev Jan 17, 2018
@mrdoob
Copy link
Owner

mrdoob commented Jan 17, 2018

Thanks!

@mrdoob mrdoob added this to the r90 milestone Jan 17, 2018
@mrdoob
Copy link
Owner

mrdoob commented Jan 17, 2018

Is #12464 still needed?

@takahirox
Copy link
Collaborator Author

Yes, that's for another issue.

@Mugen87 Mugen87 mentioned this pull request Feb 13, 2018
Closed
11 tasks
@takahirox takahirox deleted the ReleaseCurrentRenderList branch February 24, 2018 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r90
Development

Successfully merging this pull request may close these issues.
2 participants
@takahirox @mrdoob