Prevent memory leak in WebGLRenderList #13249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that WebGLRenderList was maintaining references to objects I had previously removed from my scene.
This is a problem if your scene currently has less objects than it did in the past.
I see that a dispose() method was added, but that clobbers the entire list, unnecessarily. I don't think it should be up to the three.js user that they should be disposing this renderList, either, it seems very much like an implementation detail.
This PR makes it so that any renderList slots that aren't currently used are cleared out, preventing memory leaks for everybody.