-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples: Make domElement to a mandatory parameter for all controls. #17612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
changed the title
Examples: Make domElement mandatory parameter.
Examples: Make domElement mandatory parameter for all controls.
Sep 30, 2019
Mugen87
changed the title
Examples: Make domElement mandatory parameter for all controls.
Examples: Make domElement to a mandatory parameter for all controls.
Sep 30, 2019
Looking great! |
mrdoob
reviewed
Oct 10, 2019
mrdoob
reviewed
Oct 10, 2019
mrdoob
reviewed
Oct 10, 2019
Thanks! |
This was referenced Oct 11, 2019
EliasHasle
added a commit
to EliasHasle/three.js
that referenced
this pull request
Oct 16, 2019
I'm sorry, I'm a bit lost with this change here. I get it is supposed to get something fixed, but I do not get how I'm supposed to handle this - if up till now I could get away with controls = new THREE.OrbitControls( camera ) - where should I add a change. Is there an example somewhere with what changes I should do? |
Instead of const controls = new THREE.OrbitControls( camera ); do this: const controls = new THREE.OrbitControls( camera, renderer.domElement ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement of #16336
This PR makes
domElement
to a mandatory ctor parameter. No default value (likedocument
) is set anymore.OrbitControls
andTrackballControls
have an additional check which warns users when they usedocument
as a ctor argument. The reason for this is explained here: #16326 (comment)