FileLoader: Support environments without ReadableStream #23032
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #23015
Description
Adds a check to FileLoader to skip using ReadableStream and
response.body.getReader
if they are not supported by the current environment. Both of these were only added to Firefox within the last couple years and it seems most polyfills do not provide support for these, either.With this change you can use the
node-fetch
package to enable FileLoader in node environments:This doesn't completely address the react-native case, though. In order for that to be fixed
FileReader.readAsArrayBuffer
must be implemented in react native because it's used by the fetch polyfill they're depending on. facebook/react-native#30769 has implemented the function but unfortunately it's gotten no attention from the project.cc @CodyJasonBennett