Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: CCDIKSolver with generic SkinnedMesh #23449

Merged
merged 11 commits into from
Apr 27, 2022

Conversation

abernier
Copy link
Contributor

@abernier abernier commented Feb 9, 2022

Note Merged
see CCDIKSolver doc

Align the CCDIKSolver documentation with its description, which says it works with a generic SkinnedMesh (not only MMDLoader).

Adding an embed example, based on the SkinnedMesh one.

See:

@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 24, 2022

Looks good to me!

@takahirox Are you fine with this change?

@Mugen87 Mugen87 added this to the r140 milestone Apr 24, 2022
@takahirox
Copy link
Collaborator

@takahirox Are you fine with this change?

Yes, this change looks good. CCDIKSolver is originally made for MMD but also designed for generic use. And we have good document now. So mentioning that it works with a generic SkinnedMesh (not only MMDLoader) sounds good to me.

@Mugen87 Mugen87 merged commit d4ac841 into mrdoob:dev Apr 27, 2022
@mrdoob
Copy link
Owner

mrdoob commented Apr 28, 2022

Thanks!

abernier added a commit to abernier/three.js that referenced this pull request Sep 16, 2022
* doc: CCDIKSolver with generic SkinnedMesh

* whitespaces fix

* tabs indentation

* tweaks

* Update CCDIKSolver.html

* typo

* lint fixes

* zh version

* oops
@abernier abernier deleted the ccdiksolver-doc-example branch September 22, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants