Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileLoader: Added workaround for Alipay browser's bug. #23548

Merged
merged 2 commits into from
Feb 23, 2022

Conversation

neciszhang
Copy link
Contributor

@neciszhang neciszhang commented Feb 21, 2022

Related issue: #23015

Description
In Alipay browser, response.body is undefined, when i change it,I load .Glb file successfully in Alipay browser.

@Mugen87 Mugen87 changed the title fix response.body bug FileLoader: Fix response.body bug. Feb 21, 2022
@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 21, 2022

In Alipay browser, response.body is undefined

Just for clarification: Is it spec-compliant that response.body can be undefined? Or is this a browser bug?

@neciszhang
Copy link
Contributor Author

neciszhang commented Feb 22, 2022

In Alipay browser, response.body is undefined

Just for clarification: Is it spec-compliant that response.body can be undefined? Or is this a browser bug?
Here is the full response:
image
And "typeof ReadableStream=function" in Alipay Browser .

@neciszhang
Copy link
Contributor Author

neciszhang commented Feb 22, 2022

In Alipay browser, response.body is undefined

Just for clarification: Is it spec-compliant that response.body can be undefined? Or is this a browser bug?

The response.body document,click here.

@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 22, 2022

Um, in this case it looks like a browser issue, no? Have you considered to report it to Alipay?

@mrdoob
Copy link
Owner

mrdoob commented Feb 23, 2022

Hmm, I guess the workaround is not too bad in this case...

@mrdoob mrdoob changed the title FileLoader: Fix response.body bug. FileLoader: Added workaround for Alipay browser's bug. Feb 23, 2022
@mrdoob mrdoob added this to the r138 milestone Feb 23, 2022
@mrdoob mrdoob merged commit 67b7a0c into mrdoob:dev Feb 23, 2022
donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
* fix response.body bug

* Update FileLoader.js

Co-authored-by: 家靖 <zhangjiajing.zjj@alibaba-inc.com>
Co-authored-by: mrdoob <info@mrdoob.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants