Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OculusHandPointerModel: cleanup on disconnect, implement dispose #26262

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

CodyJasonBennett
Copy link
Contributor

Related issue: #XXXX (mirrors pmndrs/three-stdlib#266)

Description

Fixes an issue in OculusHandPointerModel where it would repeatedly create cursors on input change and create a memory leak. Additionally, I've implemented dispose to cleanup its listeners and to match the other WebXR classes.

@Mugen87 Mugen87 added this to the r154 milestone Jun 19, 2023
@Mugen87 Mugen87 merged commit 21b8fa1 into mrdoob:dev Jun 20, 2023
@CodyJasonBennett CodyJasonBennett deleted the fix/oculuspointer-dispose branch June 20, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants