Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Puppeteer E2E test: Replace BrowserFetcher with @puppeteer/browsers #26282

Merged
merged 4 commits into from
Jun 20, 2023
Merged

Puppeteer E2E test: Replace BrowserFetcher with @puppeteer/browsers #26282

merged 4 commits into from
Jun 20, 2023

Conversation

LeviPesin
Copy link
Contributor

Related issue: #26008 (comment)

@github-actions
Copy link

github-actions bot commented Jun 17, 2023 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
642.8 kB (159.4 kB) 642.8 kB (159.4 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
436.1 kB (105.6 kB) 436.1 kB (105.6 kB) +0 B

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 17, 2023
View reviewed changes
test/e2e/puppeteer.js Fixed Show fixed Hide fixed
@Mugen87 Mugen87 added this to the r154 milestone Jun 20, 2023
@Mugen87 Mugen87 merged commit 36243d1 into mrdoob:dev Jun 20, 2023
@LeviPesin LeviPesin deleted the puppeteer-use-browsers branch June 20, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r154
Development

Successfully merging this pull request may close these issues.
2 participants
@LeviPesin @Mugen87